Close open file descriptors and update to fs' promise API#3
Open
AndreasWJ wants to merge 1 commit intofwdcp:masterfrom
Open
Close open file descriptors and update to fs' promise API#3AndreasWJ wants to merge 1 commit intofwdcp:masterfrom
AndreasWJ wants to merge 1 commit intofwdcp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
First off, thanks for releasing this module, it has helped me out a lot!
While using node-vpk I noticed that the error "EMFILE: Too many files open" would be thrown from time to time working with many VPK files. I was able to fix the error by closing the module's open file descriptors. In the mean time I upgraded to fs' promise API.
If you would like me to remove the fs promises I can do so. But to me it made more sense rewriting getFiles(...) as asynchronous since it deals with the file system.